Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1934)

Unified Diff: content/renderer/render_view_impl.cc

Issue 59553003: Do not show IME on every touchend event when input field has focus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweaking unit test further Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 339cee33b3d6f9eecdcd7c72afdcf2832eff889c..9f20096a342748fa21d5810005f94f16d31054bd 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2829,7 +2829,12 @@ void RenderViewImpl::focusPrevious() {
}
void RenderViewImpl::focusedNodeChanged(const WebNode& node) {
klobag.chromium 2014/01/23 23:01:49 If user dismisses the OSK, and re-tap the text fie
aurimas (slooooooooow) 2014/01/23 23:05:22 I think klobag@ means when you use a back key on A
- Send(new ViewHostMsg_FocusedNodeChanged(routing_id_, IsEditableNode(node)));
+ bool is_editable_node = IsEditableNode(node);
+#if defined(OS_ANDROID)
+ if (is_editable_node)
+ UpdateTextInputState(true, true);
+#endif
+ Send(new ViewHostMsg_FocusedNodeChanged(routing_id_, is_editable_node));
FOR_EACH_OBSERVER(RenderViewObserver, observers_, FocusedNodeChanged(node));
}

Powered by Google App Engine
This is Rietveld 408576698