Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: content/renderer/render_view_impl.cc

Issue 59553003: Do not show IME on every touchend event when input field has focus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweaking unit test further Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_view_impl.h" 5 #include "content/renderer/render_view_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 2810 matching lines...) Expand 10 before | Expand all | Expand 10 after
2821 } 2821 }
2822 2822
2823 void RenderViewImpl::focusNext() { 2823 void RenderViewImpl::focusNext() {
2824 Send(new ViewHostMsg_TakeFocus(routing_id_, false)); 2824 Send(new ViewHostMsg_TakeFocus(routing_id_, false));
2825 } 2825 }
2826 2826
2827 void RenderViewImpl::focusPrevious() { 2827 void RenderViewImpl::focusPrevious() {
2828 Send(new ViewHostMsg_TakeFocus(routing_id_, true)); 2828 Send(new ViewHostMsg_TakeFocus(routing_id_, true));
2829 } 2829 }
2830 2830
2831 void RenderViewImpl::focusedNodeChanged(const WebNode& node) { 2831 void RenderViewImpl::focusedNodeChanged(const WebNode& node) {
klobag.chromium 2014/01/23 23:01:49 If user dismisses the OSK, and re-tap the text fie
aurimas (slooooooooow) 2014/01/23 23:05:22 I think klobag@ means when you use a back key on A
2832 Send(new ViewHostMsg_FocusedNodeChanged(routing_id_, IsEditableNode(node))); 2832 bool is_editable_node = IsEditableNode(node);
2833 #if defined(OS_ANDROID)
2834 if (is_editable_node)
2835 UpdateTextInputState(true, true);
2836 #endif
2837 Send(new ViewHostMsg_FocusedNodeChanged(routing_id_, is_editable_node));
2833 2838
2834 FOR_EACH_OBSERVER(RenderViewObserver, observers_, FocusedNodeChanged(node)); 2839 FOR_EACH_OBSERVER(RenderViewObserver, observers_, FocusedNodeChanged(node));
2835 } 2840 }
2836 2841
2837 void RenderViewImpl::numberOfWheelEventHandlersChanged(unsigned num_handlers) { 2842 void RenderViewImpl::numberOfWheelEventHandlersChanged(unsigned num_handlers) {
2838 Send(new ViewHostMsg_DidChangeNumWheelEvents(routing_id_, num_handlers)); 2843 Send(new ViewHostMsg_DidChangeNumWheelEvents(routing_id_, num_handlers));
2839 } 2844 }
2840 2845
2841 void RenderViewImpl::didUpdateLayout() { 2846 void RenderViewImpl::didUpdateLayout() {
2842 FOR_EACH_OBSERVER(RenderViewObserver, observers_, DidUpdateLayout()); 2847 FOR_EACH_OBSERVER(RenderViewObserver, observers_, DidUpdateLayout());
(...skipping 3623 matching lines...) Expand 10 before | Expand all | Expand 10 after
6466 for (size_t i = 0; i < icon_urls.size(); i++) { 6471 for (size_t i = 0; i < icon_urls.size(); i++) {
6467 WebURL url = icon_urls[i].iconURL(); 6472 WebURL url = icon_urls[i].iconURL();
6468 if (!url.isEmpty()) 6473 if (!url.isEmpty())
6469 urls.push_back(FaviconURL(url, 6474 urls.push_back(FaviconURL(url,
6470 ToFaviconType(icon_urls[i].iconType()))); 6475 ToFaviconType(icon_urls[i].iconType())));
6471 } 6476 }
6472 SendUpdateFaviconURL(urls); 6477 SendUpdateFaviconURL(urls);
6473 } 6478 }
6474 6479
6475 } // namespace content 6480 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698