Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: build/android/gyp/create_native_libraries_header.py

Issue 59533009: Check library version and handle library load errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to second round of review comments. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/gyp/create_native_libraries_header.py
diff --git a/build/android/gyp/create_native_libraries_header.py b/build/android/gyp/create_native_libraries_header.py
index 5c1bf1b6a333f4197698e5abd4a41e635f26c879..b44239d24a6d5c5d63e37a71d55894dafe78e0ee 100755
--- a/build/android/gyp/create_native_libraries_header.py
+++ b/build/android/gyp/create_native_libraries_header.py
@@ -21,15 +21,19 @@ from util import build_utils
def main(argv):
parser = optparse.OptionParser()
- parser.add_option('--output', help='Path to generated .java file')
+ parser.add_option('--native-library-list',
+ help='Path to generated .java file containing library list')
+ parser.add_option('--version-output',
+ help='Path to generated .java file containing version name')
parser.add_option('--ordered-libraries',
help='Path to json file containing list of ordered libraries')
- parser.add_option('--stamp', help='Path to touch on success')
+ parser.add_option('--version-name',
+ help='expected version name of native library')
# args should be the list of libraries in dependency order.
options, _ = parser.parse_args()
- build_utils.MakeDirectory(os.path.dirname(options.output))
+ build_utils.MakeDirectory(os.path.dirname(options.native_library_list))
with open(options.ordered_libraries, 'r') as libfile:
libraries = json.load(libfile)
@@ -39,12 +43,11 @@ def main(argv):
libraries = ['"' + lib[3:-3] + '"' for lib in libraries]
array = '= { ' + ', '.join(libraries) + '}';
- with open(options.output, 'w') as header:
+ with open(options.native_library_list, 'w') as header:
header.write(array)
- if options.stamp:
- build_utils.Touch(options.stamp)
-
+ with open(options.version_output, 'w') as header:
+ header.write('= "%s"' % options.version_name)
if __name__ == '__main__':
sys.exit(main(sys.argv))

Powered by Google App Engine
This is Rietveld 408576698