android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java - Issue 59533009: Check library version and handle library load errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

Issue 59533009: Check library version and handle library load errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to second round of review comments. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/generated_src/org/chromium/content/app/NativeLibraries.java ('k') | build/android/gyp/create_native_libraries_header.py » ('j') | build/android/gyp/create_native_libraries_header.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java b/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

index c0657a3b0e3da4658e86608042657cbbdc761d4e..d1bd8e7c292f1640a5236308554fdc0df8c8e1b9 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

@@ -45,9 +45,11 @@ public abstract class AwBrowserProcess {

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@Override

public void run() {

- if( !BrowserStartupController.get(context).startBrowserProcessesSync(

- BrowserStartupController.MAX_RENDERERS_SINGLE_PROCESS)) {

- throw new RuntimeException("Cannot initialize WebView");

+ try {

+ BrowserStartupController.get(context).startBrowserProcessesSync(

+ BrowserStartupController.MAX_RENDERERS_SINGLE_PROCESS);

+ } catch (ProcessInitException e) {

+ throw new RuntimeException("Cannot initialize WebView", e);

}

});