android_webview/java/generated_src/org/chromium/content/app/NativeLibraries.java - Issue 59533009: Check library version and handle library load errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/generated_src/org/chromium/content/app/NativeLibraries.java

Issue 59533009: Check library version and handle library load errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to second round of review comments. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java » ('j') | build/android/gyp/create_native_libraries_header.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/generated_src/org/chromium/content/app/NativeLibraries.java

diff --git a/android_webview/java/generated_src/org/chromium/content/app/NativeLibraries.java b/android_webview/java/generated_src/org/chromium/content/app/NativeLibraries.java

index 04db5361de651daf670a222e88bf86a1dc11294d..bb7d747b0a19ad3e3e2e36bcad6cbd9f6cac655e 100644

--- a/android_webview/java/generated_src/org/chromium/content/app/NativeLibraries.java

+++ b/android_webview/java/generated_src/org/chromium/content/app/NativeLibraries.java

@@ -16,5 +16,10 @@ public class NativeLibraries {

// This is the list of native libraries to load. In the normal chromium build, this would be

// automatically generated.

// TODO(torne, cjhopman): Use a generated file for this.

- static String[] libraries = { "webviewchromium" };

+ static final String[] LIBRARIES = { "webviewchromium" };

+ // This should match the version name string returned by the native library.

+ // TODO(aberent) The Webview native library currently returns an empty string; change this

+ // to a string generated at compile time, and incorporate that string in a generated

+ // replacement for this file.

+ static String VERSION_NAME = "";

}