Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: chrome/browser/resources/print_preview/print_preview_animations.js

Issue 595153003: Compile print_preview, part 5: reduce down to 104 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview_4
Patch Set: revert movement of enums: now handle in compiler pass Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/print_preview_animations.js
diff --git a/chrome/browser/resources/print_preview/print_preview_animations.js b/chrome/browser/resources/print_preview/print_preview_animations.js
index b864d552aa3d40fd2b9fca007d549cbfaa31cfa7..72369b6b03d6336b683272aa56e284294b067579 100644
--- a/chrome/browser/resources/print_preview/print_preview_animations.js
+++ b/chrome/browser/resources/print_preview/print_preview_animations.js
@@ -73,6 +73,7 @@ function fadeOutElement(el) {
el.style.height = 'auto';
var height = el.offsetHeight;
el.style.height = height + 'px';
+ /** @suppress {suspiciousCode} */
el.offsetHeight; // Should force an update of the computed style.
animationEventTracker_.add(
el, 'webkitTransitionEnd', onFadeOutTransitionEnd.bind(el), false);
@@ -129,9 +130,11 @@ function fadeInOption(el, opt_justShow) {
// To make the option visible during the first fade in.
el.hidden = false;
- var leftColumn = el.querySelector('.left-column');
+ var leftColumn = assertInstanceof(el.querySelector('.left-column'),
+ HTMLElement);
wrapContentsInDiv(leftColumn, ['invisible']);
- var rightColumn = el.querySelector('.right-column');
+ var rightColumn = assertInstanceof(el.querySelector('.right-column'),
+ HTMLElement);
wrapContentsInDiv(rightColumn, ['invisible']);
var toAnimate = el.querySelectorAll('.collapsible');
@@ -150,9 +153,11 @@ function fadeOutOption(el, opt_justHide) {
if (!el.classList.contains('visible'))
return;
- var leftColumn = el.querySelector('.left-column');
+ var leftColumn = assertInstanceof(el.querySelector('.left-column'),
+ HTMLElement);
wrapContentsInDiv(leftColumn, ['visible']);
- var rightColumn = el.querySelector('.right-column');
+ var rightColumn = assertInstanceof(el.querySelector('.right-column'),
+ HTMLElement);
wrapContentsInDiv(rightColumn, ['visible']);
var toAnimate = el.querySelectorAll('.collapsible');
@@ -173,7 +178,7 @@ function fadeOutOption(el, opt_justHide) {
* |classes| in the new div, only if has not been already done. It is necessary
* for animating the height of table cells.
* @param {HTMLElement} el The element to be processed.
- * @param {array} classes The css classes to add.
+ * @param {Array} classes The css classes to add.
*/
function wrapContentsInDiv(el, classes) {
var div = el.querySelector('div');

Powered by Google App Engine
This is Rietveld 408576698