chrome/browser/resources/print_preview/preview_generator.js - Issue 595153003: Compile print_preview, part 5: reduce down to 104 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/preview_generator.js

Issue 595153003: Compile print_preview, part 5: reduce down to 104 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview_4

Patch Set: revert movement of enums: now handle in compiler pass Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/print_preview/cloud_print_interface.js ('K') | « chrome/browser/resources/print_preview/native_layer.js ('k') | chrome/browser/resources/print_preview/print_preview_animations.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/preview_generator.js

diff --git a/chrome/browser/resources/print_preview/preview_generator.js b/chrome/browser/resources/print_preview/preview_generator.js

index bcbe95fe64ae8a8d73fcefa9611c185b34927a91..215f5249e994a68566cf398c08111365ecae2676 100644

--- a/chrome/browser/resources/print_preview/preview_generator.js

+++ b/chrome/browser/resources/print_preview/preview_generator.js

@@ -59,7 +59,9 @@ cr.define('print_preview', function() {

/**

* Media size to generate preview with. {@code null} indicates default size.

- * @type {cp.cdd.MediaSizeTicketItem}

+ * Actual type is cp.cdd.MediaSizeTicketItem which is generated from proto

+ * defs.

Dan Beam 2014/09/29 22:13:41 why don't we have @externs for protos?

+ * @type {print_preview.ValueType}

* @private

this.mediaSize_ = null;

@@ -94,7 +96,7 @@ cr.define('print_preview', function() {

/**

* Page ranges setting used used to generate the last preview.

- * @type {!Array.<object.<{from: number, to: number}>>}

+ * @type {Array.<Object.<{from: number, to: number}>>}

* @private

this.pageRanges_ = null;