Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 595023: ARM optimize loading of immediates. (Closed)

Created:
10 years, 10 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

ARM optimize loading of immediates. Better use of mov/mvn and allows using two instructions to avoid one constant pool load. (Made redundant by using movw,movt)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -37 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 6 chunks +247 lines, -36 lines 0 comments Download
M src/arm/simulator-arm.cc View 2 chunks +6 lines, -1 line 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +122 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Medium sized, but complicated, review.
10 years, 10 months ago (2010-02-10 17:14:50 UTC) #1
Lasse Reichstein
10 years, 10 months ago (2010-02-10 17:46:18 UTC) #2
Hold the review. There seems to be more bugs.

Powered by Google App Engine
This is Rietveld 408576698