Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: tools/push-to-trunk/auto_tag.py

Issue 594773003: Refactoring: Remove global configs in release scripts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove global configs. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/push-to-trunk/auto_tag.py
diff --git a/tools/push-to-trunk/auto_tag.py b/tools/push-to-trunk/auto_tag.py
index 080089682c3b7a863c8265e9d94d06af5e11c468..175e10e7274b312cf75cc2391a59e07bc6d1c245 100755
--- a/tools/push-to-trunk/auto_tag.py
+++ b/tools/push-to-trunk/auto_tag.py
@@ -8,11 +8,6 @@ import sys
from common_includes import *
-CONFIG = {
- BRANCHNAME: "auto-tag-v8",
- PERSISTFILE_BASENAME: "/tmp/v8-auto-tag-tempfile",
-}
-
class Preparation(Step):
MESSAGE = "Preparation."
@@ -28,7 +23,7 @@ class GetTags(Step):
MESSAGE = "Get all V8 tags."
def RunStep(self):
- self.GitCreateBranch(self._config[BRANCHNAME])
+ self.GitCreateBranch(self._config["BRANCHNAME"])
# Get remote tags.
tags = filter(lambda s: re.match(r"^svn/tags/[\d+\.]+$", s),
@@ -182,6 +177,12 @@ class AutoTag(ScriptsBase):
options.force_upload = True
return True
+ def _Config(self):
+ return {
+ "BRANCHNAME": "auto-tag-v8",
+ "PERSISTFILE_BASENAME": "/tmp/v8-auto-tag-tempfile",
+ }
+
def _Steps(self):
return [
Preparation,
@@ -195,4 +196,4 @@ class AutoTag(ScriptsBase):
if __name__ == "__main__": # pragma: no cover
- sys.exit(AutoTag(CONFIG).Run())
+ sys.exit(AutoTag().Run())

Powered by Google App Engine
This is Rietveld 408576698