Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: tools/push-to-trunk/bump_up_version.py

Issue 594773003: Refactoring: Remove global configs in release scripts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove global configs. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/push-to-trunk/bump_up_version.py
diff --git a/tools/push-to-trunk/bump_up_version.py b/tools/push-to-trunk/bump_up_version.py
index 2e5d08fdc60fdb8a1c1a27aca0653438ebc4984f..c9f052b893f9715ac3da58f5c8292fe4797c9fbd 100755
--- a/tools/push-to-trunk/bump_up_version.py
+++ b/tools/push-to-trunk/bump_up_version.py
@@ -25,11 +25,6 @@ import sys
from common_includes import *
-CONFIG = {
- PERSISTFILE_BASENAME: "/tmp/v8-bump-up-version-tempfile",
- PATCH_FILE: "/tmp/v8-bump-up-version-tempfile-patch-file",
-}
-
VERSION_BRANCH = "auto-bump-up-version"
@@ -227,6 +222,11 @@ class BumpUpVersion(ScriptsBase):
options.force_upload = True
return True
+ def _Config(self):
+ return {
+ "PERSISTFILE_BASENAME": "/tmp/v8-bump-up-version-tempfile",
+ }
+
def _Steps(self):
return [
Preparation,
@@ -242,4 +242,4 @@ class BumpUpVersion(ScriptsBase):
]
if __name__ == "__main__": # pragma: no cover
- sys.exit(BumpUpVersion(CONFIG).Run())
+ sys.exit(BumpUpVersion().Run())

Powered by Google App Engine
This is Rietveld 408576698