Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 594773003: Refactoring: Remove global configs in release scripts. (Closed)

Created:
6 years, 3 months ago by Michael Achenbach
Modified:
6 years, 2 months ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Refactoring: Remove global configs in release scripts. TBR=tandrii@chromium.org TEST=script_test.py Committed: https://code.google.com/p/v8/source/detail?r=24154

Patch Set 1 : Use strings literals as dict keys. #

Patch Set 2 : Remove global configs. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -228 lines) Patch
M tools/push-to-trunk/auto_push.py View 1 5 chunks +9 lines, -12 lines 0 comments Download
M tools/push-to-trunk/auto_roll.py View 1 5 chunks +10 lines, -14 lines 0 comments Download
M tools/push-to-trunk/auto_tag.py View 1 4 chunks +8 lines, -7 lines 0 comments Download
M tools/push-to-trunk/bump_up_version.py View 1 3 chunks +6 lines, -6 lines 0 comments Download
M tools/push-to-trunk/chromium_roll.py View 1 4 chunks +7 lines, -8 lines 0 comments Download
M tools/push-to-trunk/common_includes.py View 1 7 chunks +15 lines, -17 lines 2 comments Download
M tools/push-to-trunk/merge_to_branch.py View 1 6 chunks +20 lines, -25 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 1 13 chunks +38 lines, -39 lines 0 comments Download
M tools/push-to-trunk/releases.py View 1 6 chunks +12 lines, -8 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 41 chunks +91 lines, -92 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
PTAL
6 years, 3 months ago (2014-09-23 13:23:15 UTC) #2
Michael Achenbach
Committed patchset #2 (id:20001) manually as 24154 (presubmit successful).
6 years, 3 months ago (2014-09-23 14:41:50 UTC) #3
tandrii(chromium)
lgtm https://codereview.chromium.org/594773003/diff/20001/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/594773003/diff/20001/tools/push-to-trunk/common_includes.py#newcode603 tools/push-to-trunk/common_includes.py:603: # TODO(machenbach): Move static config here. Is this ...
6 years, 3 months ago (2014-09-23 14:45:25 UTC) #4
Michael Achenbach
6 years, 2 months ago (2014-09-25 08:17:41 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/594773003/diff/20001/tools/push-to-trunk/comm...
File tools/push-to-trunk/common_includes.py (right):

https://codereview.chromium.org/594773003/diff/20001/tools/push-to-trunk/comm...
tools/push-to-trunk/common_includes.py:603: # TODO(machenbach): Move static
config here.
On 2014/09/23 14:45:25, tandrii wrote:
> Is this still TODO?

Ups no. This is exactly what the todo was about... will clean up in a follow up.

Powered by Google App Engine
This is Rietveld 408576698