media/blink/buffered_data_source.cc - Issue 594733004: BufferedDataSource: don't reallocate buffer unnecessarily

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/buffered_data_source.cc

Issue 594733004: BufferedDataSource: don't reallocate buffer unnecessarily (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/blink/buffered_data_source.cc

diff --git a/media/blink/buffered_data_source.cc b/media/blink/buffered_data_source.cc

index 91ed1a254c8c43cba43aa8011d0e2501cb6a3c51..8559661781c3573cc109fc8bd20a3de1185f98c2 100644

--- a/media/blink/buffered_data_source.cc

+++ b/media/blink/buffered_data_source.cc

@@ -316,6 +316,7 @@ void BufferedDataSource::ReadInternal() {

// to write to.

if (size > intermediate_read_buffer_size_) {

intermediate_read_buffer_.reset(new uint8[size]);

+ intermediate_read_buffer_size_ = size;

xhwang 2014/09/23 20:56:22 Thanks for fixing this! The fix looks good. But I

}

// Perform the actual read with BufferedResourceLoader.

« no previous file with comments | « no previous file | no next file » | no next file with comments »