BufferedDataSource: don't reallocate buffer unnecessarily

media/blink/buffered_data_source.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/buffered_data_source.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/single_thread_task_runner.h"
 #include "media/base/media_log.h"
@@ skipping 298 matching lines @@
       return;
 
     position = read_op_->position();
     size = read_op_->size();
   }
 
   // First we prepare the intermediate read buffer for BufferedResourceLoader
   // to write to.
   if (size > intermediate_read_buffer_size_) {
     intermediate_read_buffer_.reset(new uint8[size]);
+    intermediate_read_buffer_size_ = size;

[xhwang, 2014/09/23 20:56:22]

Thanks for fixing this! The fix looks good. But I wonder can we just use a
vector<uint8> for intermediate_read_buffer_ so that we can drop
intermediate_read_buffer_size_ altogether...

   }
 
   // Perform the actual read with BufferedResourceLoader.
   loader_->Read(position,
                 size,
                 intermediate_read_buffer_.get(),
                 base::Bind(&BufferedDataSource::ReadCallback,
                            weak_factory_.GetWeakPtr()));
 }
 
@@ skipping 197 matching lines @@
   }
 
   // If media is currently playing or the page indicated preload=auto or the
   // the server does not support the byte range request or we do not want to go
   // too far ahead of the read head, use threshold strategy to enable/disable
   // deferring when the buffer is full/depleted.
   loader_->UpdateDeferStrategy(BufferedResourceLoader::kCapacityDefer);
 }
 
 }  // namespace media