Source/core/html/HTMLTextAreaElement.h - Issue 59463007: Have Element::ensureUserAgentShadowRoot() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextAreaElement.h

Issue 59463007: Have Element::ensureUserAgentShadowRoot() return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add extra assertion Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLTextAreaElement.h

diff --git a/Source/core/html/HTMLTextAreaElement.h b/Source/core/html/HTMLTextAreaElement.h

index 1b8dd6b3270f9e93e3143b61e3709e529e9aaf92..fa2c6cc0d67cbbf6594711b6b5a84ae2bfd17c1d 100644

--- a/Source/core/html/HTMLTextAreaElement.h

+++ b/Source/core/html/HTMLTextAreaElement.h

@@ -64,7 +64,7 @@ private:

enum WrapMethod { NoWrap, SoftWrap, HardWrap };

- virtual void didAddUserAgentShadowRoot(ShadowRoot*) OVERRIDE;

+ virtual void didAddUserAgentShadowRoot(ShadowRoot&) OVERRIDE;

// FIXME: Author shadows should be allowed

// https://bugs.webkit.org/show_bug.cgi?id=92608

virtual bool areAuthorShadowsAllowed() const OVERRIDE { return false; }

« no previous file with comments | « Source/core/html/HTMLSummaryElement.cpp ('k') | Source/core/html/HTMLTextAreaElement.cpp » ('j') | no next file with comments »