Source/core/html/HTMLSummaryElement.cpp - Issue 59463007: Have Element::ensureUserAgentShadowRoot() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSummaryElement.cpp

Issue 59463007: Have Element::ensureUserAgentShadowRoot() return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add extra assertion Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLSummaryElement.cpp

diff --git a/Source/core/html/HTMLSummaryElement.cpp b/Source/core/html/HTMLSummaryElement.cpp

index 379b4a5d49cb967915093ca64ab44566e99a17da..02880b5d81dcd8ffd104d3059ddcd3fdb070b86c 100644

--- a/Source/core/html/HTMLSummaryElement.cpp

+++ b/Source/core/html/HTMLSummaryElement.cpp

@@ -53,10 +53,10 @@ RenderObject* HTMLSummaryElement::createRenderer(RenderStyle*)

return new RenderBlockFlow(this);

}

-void HTMLSummaryElement::didAddUserAgentShadowRoot(ShadowRoot* root)

+void HTMLSummaryElement::didAddUserAgentShadowRoot(ShadowRoot& root)

{

- root->appendChild(DetailsMarkerControl::create(document()));

- root->appendChild(HTMLContentElement::create(document()));

+ root.appendChild(DetailsMarkerControl::create(document()));

+ root.appendChild(HTMLContentElement::create(document()));

}

HTMLDetailsElement* HTMLSummaryElement::detailsElement() const

« no previous file with comments | « Source/core/html/HTMLSummaryElement.h ('k') | Source/core/html/HTMLTextAreaElement.h » ('j') | no next file with comments »