Source/core/html/HTMLTextAreaElement.cpp - Issue 59463007: Have Element::ensureUserAgentShadowRoot() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextAreaElement.cpp

Issue 59463007: Have Element::ensureUserAgentShadowRoot() return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add extra assertion Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLTextAreaElement.cpp

diff --git a/Source/core/html/HTMLTextAreaElement.cpp b/Source/core/html/HTMLTextAreaElement.cpp

index 56deba03b1fd142a3164ce1c9e3e8d67b387f584..a2aa3218e3b1313c276df2aa8dcdb00622253942 100644

--- a/Source/core/html/HTMLTextAreaElement.cpp

+++ b/Source/core/html/HTMLTextAreaElement.cpp

@@ -95,9 +95,9 @@ PassRefPtr<HTMLTextAreaElement> HTMLTextAreaElement::create(const QualifiedName&

return textArea.release();

}

-void HTMLTextAreaElement::didAddUserAgentShadowRoot(ShadowRoot* root)

+void HTMLTextAreaElement::didAddUserAgentShadowRoot(ShadowRoot& root)

{

- root->appendChild(TextControlInnerTextElement::create(document()));

+ root.appendChild(TextControlInnerTextElement::create(document()));

}

const AtomicString& HTMLTextAreaElement::formControlType() const

« no previous file with comments | « Source/core/html/HTMLTextAreaElement.h ('k') | Source/core/html/shadow/MediaControlElements.cpp » ('j') | no next file with comments »