Source/core/html/HTMLKeygenElement.cpp - Issue 59463007: Have Element::ensureUserAgentShadowRoot() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLKeygenElement.cpp

Issue 59463007: Have Element::ensureUserAgentShadowRoot() return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add extra assertion Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLKeygenElement.cpp

diff --git a/Source/core/html/HTMLKeygenElement.cpp b/Source/core/html/HTMLKeygenElement.cpp

index 4b20d877b12f812918eb2e722724f2bd0cf73854..447922f6fdba0e33a3e7fa70e4d4d993b9b20b1f 100644

--- a/Source/core/html/HTMLKeygenElement.cpp

+++ b/Source/core/html/HTMLKeygenElement.cpp

@@ -50,7 +50,7 @@ HTMLKeygenElement::HTMLKeygenElement(const QualifiedName& tagName, Document& doc

ensureUserAgentShadowRoot();

}

-void HTMLKeygenElement::didAddUserAgentShadowRoot(ShadowRoot* root)

+void HTMLKeygenElement::didAddUserAgentShadowRoot(ShadowRoot& root)

{

DEFINE_STATIC_LOCAL(AtomicString, keygenSelectPseudoId, ("-webkit-keygen-select", AtomicString::ConstructFromLiteral));

@@ -66,7 +66,7 @@ void HTMLKeygenElement::didAddUserAgentShadowRoot(ShadowRoot* root)

select->appendChild(option);

}

- root->appendChild(select);

+ root.appendChild(select);

}

void HTMLKeygenElement::parseAttribute(const QualifiedName& name, const AtomicString& value)

« no previous file with comments | « Source/core/html/HTMLKeygenElement.h ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »