Source/core/html/HTMLMediaElement.cpp - Issue 59463007: Have Element::ensureUserAgentShadowRoot() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 59463007: Have Element::ensureUserAgentShadowRoot() return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add extra assertion Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 8402ac95f43129d136bc87f19f493f4cb18fb99d..dc118845d437d96c10944cb232935bd75cd05e3f 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -3594,7 +3594,7 @@ bool HTMLMediaElement::createMediaControls()

if (isFullscreen())

mediaControls->enteredFullscreen();

- ensureUserAgentShadowRoot()->appendChild(mediaControls);

+ ensureUserAgentShadowRoot().appendChild(mediaControls);

if (!controls() || !inDocument())

mediaControls->hide();

« no previous file with comments | « Source/core/html/HTMLKeygenElement.cpp ('k') | Source/core/html/HTMLMeterElement.h » ('j') | no next file with comments »