Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2645)

Unified Diff: content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix android tests Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java
diff --git a/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java b/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java
index d996fa7c14f116d3ed68fac772713c0574689f77..a515ec99c0f9a3dede57a386296ebf4ff0b8668f 100644
--- a/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java
+++ b/content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java
@@ -19,10 +19,16 @@ public class ChromiumLinkerTestApplication extends Application {
* operation. We use to link it statically to our binary, but not any more
* so that we have to install it along with other mandatory pak files.
* See src/third_party/icu/README.chromium.
+ *
+ * V8 used to be statically linked to the binary, but now it's loaded
+ * from external snapshots. Therefore we need to install such
+ * snapshots (natives_blob.bin and snapshot.bin) along with pak files.
rmcilroy 2014/10/06 15:41:03 Same comments as ChromeShellApplication.java
baixo 2014/10/07 14:53:28 Done.
*/
private static final String[] MANDATORY_PAK_FILES = new String[] {
"content_shell.pak",
- "icudtl.dat"
+ "icudtl.dat",
+ "natives_blob.bin",
+ "snapshot_blob.bin"
};
private static final String PRIVATE_DATA_DIRECTORY_SUFFIX = "chromium_linker_test";

Powered by Google App Engine
This is Rietveld 408576698