content/public/test/unittest_test_suite.cc - Issue 594603003: Infrastructure for reading V8's initial snapshot from external files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/unittest_test_suite.cc

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/test/content_test_suite_base.cc ('K') | « content/public/test/content_test_suite_base.cc ('k') | content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java » ('j') | content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/unittest_test_suite.cc

diff --git a/content/public/test/unittest_test_suite.cc b/content/public/test/unittest_test_suite.cc

index 2a6c6b8e9fbb97f4d29a8a2006557330038c3d61..4afa85d325b3bb14e4ac97586fd88be29c99e2fc 100644

--- a/content/public/test/unittest_test_suite.cc

+++ b/content/public/test/unittest_test_suite.cc

@@ -12,11 +12,20 @@

#endif

#include "third_party/WebKit/public/web/WebKit.h"

+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

+#include "gin/public/isolate_holder.h"

+#endif

namespace content {

UnitTestTestSuite::UnitTestTestSuite(base::TestSuite* test_suite)

: test_suite_(test_suite) {

DCHECK(test_suite);

+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

+ gin::IsolateHolder::LoadV8Snapshot();

rmcilroy 2014/10/06 15:41:03 You are already doing this in TestBlinkWebUnitTest

baixo 2014/10/07 14:53:27 Done.

+#endif

#if !defined(OS_IOS)

blink_test_support_.reset(new TestBlinkWebUnitTestSupport);

#endif