Infrastructure for reading V8's initial snapshot from external files

gin/public/isolate_holder.h

Index: gin/public/isolate_holder.h
diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h
index da65facff63d6fe5d20b5c4c43fc9f7239bb08b6..a45b70ff9f57d6f1544a24f121c4bc7456a556d5 100644
--- a/gin/public/isolate_holder.h
+++ b/gin/public/isolate_holder.h
@@ -6,6 +6,9 @@
 #define GIN_PUBLIC_ISOLATE_HOLDER_H_
 
 #include "base/basictypes.h"
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+#include "base/files/memory_mapped_file.h"
+#endif  // V8_USE_EXTERNAL_STARTUP_DATA
 #include "base/memory/scoped_ptr.h"
 #include "gin/gin_export.h"
 #include "v8/include/v8.h"
@@ -36,10 +39,23 @@ class GIN_EXPORT IsolateHolder {
 
   v8::Isolate* isolate() { return isolate_; }
 
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+#ifdef OS_ANDROID
+  static bool LoadV8SnapshotFD(int natives_fd, int snapshot_fd);
+#endif
+  static bool LoadV8Snapshot();
+#endif  // V8_USE_EXTERNAL_STARTUP_DATA
+
  private:
   v8::Isolate* isolate_;
   scoped_ptr<PerIsolateData> isolate_data_;
 
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+  static base::MemoryMappedFile mapped_natives;
+  static base::MemoryMappedFile mapped_snapshot;
+  static bool read_snapshot;

[rmcilroy, 2014/09/23 10:04:20]

You shouldn't have these static members here (you are using static globals in
isolate_holder.cc, and similarly to the comment I made there, we don't allow
static member variables in classes (other than "static const" POD types).

[baixo, 2014/09/23 11:36:46]

Done.

+#endif  // V8_USE_EXTERNAL_STARTUP_DATA
+
   DISALLOW_COPY_AND_ASSIGN(IsolateHolder);
 };