Infrastructure for reading V8's initial snapshot from external files

gin/public/isolate_holder.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GIN_PUBLIC_ISOLATE_HOLDER_H_
 #define GIN_PUBLIC_ISOLATE_HOLDER_H_
 
 #include "base/basictypes.h"
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+#include "base/files/memory_mapped_file.h"
+#endif  // V8_USE_EXTERNAL_STARTUP_DATA
 #include "base/memory/scoped_ptr.h"
 #include "gin/gin_export.h"
 #include "v8/include/v8.h"
 
 namespace gin {
 
 class PerIsolateData;
 
 // To embed Gin, first initialize gin using IsolateHolder::Initialize and then
 // create an instance of IsolateHolder to hold the v8::Isolate in which you
@@ skipping 10 matching lines @@
   IsolateHolder();
   ~IsolateHolder();
 
   // Should be invoked once before creating IsolateHolder instances to
   // initialize V8 and Gin.
   static void Initialize(ScriptMode mode,
                          v8::ArrayBuffer::Allocator* allocator);
 
   v8::Isolate* isolate() { return isolate_; }
 
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+#ifdef OS_ANDROID
+  static bool LoadV8SnapshotFD(int natives_fd, int snapshot_fd);
+#endif
+  static bool LoadV8Snapshot();
+#endif  // V8_USE_EXTERNAL_STARTUP_DATA
+
  private:
   v8::Isolate* isolate_;
   scoped_ptr<PerIsolateData> isolate_data_;
 
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+  static base::MemoryMappedFile mapped_natives;
+  static base::MemoryMappedFile mapped_snapshot;
+  static bool read_snapshot;

[rmcilroy, 2014/09/23 10:04:20]

You shouldn't have these static members here (you are using static globals in
isolate_holder.cc, and similarly to the comment I made there, we don't allow
static member variables in classes (other than "static const" POD types).

[baixo, 2014/09/23 11:36:46]

Done.

+#endif  // V8_USE_EXTERNAL_STARTUP_DATA
+
   DISALLOW_COPY_AND_ASSIGN(IsolateHolder);
 };
 
 }  // namespace gin
 
 #endif  // GIN_PUBLIC_ISOLATE_HOLDER_H_