Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 594503002: Oilpan: adjust placement of no-FrameOwner assert. (Closed)

Created:
6 years, 3 months ago by sof
Modified:
6 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: adjust placement of no-FrameOwner assert. Assert that all Frames will have been detached from their owner upon finalization, not just local ones. R=haraken, dcheng BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M Source/core/frame/Frame.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look. (Test runs show some unrelated failures only.)
6 years, 3 months ago (2014-09-22 13:52:41 UTC) #2
haraken
LGTM. The added ASSERT makes sense but dcheng should confirm.
6 years, 3 months ago (2014-09-22 13:57:44 UTC) #3
dcheng
On 2014/09/22 13:57:44, haraken wrote: > LGTM. The added ASSERT makes sense but dcheng should ...
6 years, 3 months ago (2014-09-22 15:49:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594503002/1
6 years, 3 months ago (2014-09-22 18:20:51 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 19:25:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182443

Powered by Google App Engine
This is Rietveld 408576698