Source/core/frame/Frame.cpp - Issue 594503002: Oilpan: adjust placement of no-FrameOwner assert.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/Frame.cpp

Issue 594503002: Oilpan: adjust placement of no-FrameOwner assert. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/Frame.cpp

diff --git a/Source/core/frame/Frame.cpp b/Source/core/frame/Frame.cpp

index ccd11f64b473381f03b898d94647e4b0cf61927e..302a3e1e1328c2dd483c8800fa04416b5323c0b4 100644

--- a/Source/core/frame/Frame.cpp

+++ b/Source/core/frame/Frame.cpp

@@ -81,8 +81,10 @@ Frame::Frame(FrameClient* client, FrameHost* host, FrameOwner* owner)

Frame::~Frame()

{

+#if ENABLE(OILPAN)

+ ASSERT(!m_owner);

+#else

// FIXME: We should not be doing all this work inside the destructor

-#if !ENABLE(OILPAN)

disconnectOwnerElement();

setDOMWindow(nullptr);

#endif

« no previous file with comments | « no previous file | Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »