Remove HTMLMediaElement::setPausedInternal()

Remove HTMLMediaElement::setPausedInternal()

The bits in updatePlayState() could have been inlined into stop(), but
none of it is useful:

 - isPlaying is always false because of userCancelledLoad() ->
   clearMediaPlayer(), so webMediaPlayer()->pause() is dead code.

 - refreshCachedTime() will do nothing for the same reason.

 - m_playbackProgressTimer.stop() is done by stopPeriodicTimers().

 - mediaControls()->playbackStopped() is pointless because the document
   is no longer doing layout/rendering.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182422

[philipj_slow, 2014-09-22 12:23:14]

philipj@opera.com changed reviewers:
+ fs@opera.com

[philipj_slow, 2014-09-22 12:23:15]

PTAL

[fs, 2014-09-22 12:31:05]

LGTM w/ nit

https://codereview.chromium.org/594493003/diff/1/Source/core/html/HTMLMediaEl...
File Source/core/html/HTMLMediaElement.h (right):

https://codereview.chromium.org/594493003/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.h:569: bool m_pausedInternal : 1;
Nit: Remove the actual flag as well.

[philipj_slow, 2014-09-22 13:04:48]

On 2014/09/22 12:31:05, fs wrote:
> LGTM w/ nit
> 
>
https://codereview.chromium.org/594493003/diff/1/Source/core/html/HTMLMediaEl...
> File Source/core/html/HTMLMediaElement.h (right):
> 
>
https://codereview.chromium.org/594493003/diff/1/Source/core/html/HTMLMediaEl...
> Source/core/html/HTMLMediaElement.h:569: bool m_pausedInternal : 1;
> Nit: Remove the actual flag as well.

Oh right, that was the whole point of this :)

[philipj_slow, 2014-09-22 13:06:22]

m_pausedInternal

[philipj_slow, 2014-09-22 13:06:33]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-09-22 13:07:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/594493003/20001

[commit-bot: I haz the power, 2014-09-22 14:53:10]

Committed patchset #2 (id:20001) as 182422