Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: Source/core/html/HTMLMediaElement.h

Issue 594493003: Remove HTMLMediaElement::setPausedInternal() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
429 429
430 void allowVideoRendering(); 430 void allowVideoRendering();
431 431
432 void updateVolume(); 432 void updateVolume();
433 void updatePlayState(); 433 void updatePlayState();
434 bool potentiallyPlaying() const; 434 bool potentiallyPlaying() const;
435 bool endedPlayback() const; 435 bool endedPlayback() const;
436 bool stoppedDueToErrors() const; 436 bool stoppedDueToErrors() const;
437 bool couldPlayIfEnoughData() const; 437 bool couldPlayIfEnoughData() const;
438 438
439 // Pauses playback without changing any states or generating events
440 void setPausedInternal(bool);
441
442 void setShouldDelayLoadEvent(bool); 439 void setShouldDelayLoadEvent(bool);
443 void invalidateCachedTime(); 440 void invalidateCachedTime();
444 void refreshCachedTime() const; 441 void refreshCachedTime() const;
445 442
446 bool hasMediaControls() const; 443 bool hasMediaControls() const;
447 bool createMediaControls(); 444 bool createMediaControls();
448 void configureMediaControls(); 445 void configureMediaControls();
449 446
450 virtual void* preDispatchEventHandler(Event*) OVERRIDE FINAL; 447 virtual void* preDispatchEventHandler(Event*) OVERRIDE FINAL;
451 448
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
562 bool m_muted : 1; 559 bool m_muted : 1;
563 bool m_paused : 1; 560 bool m_paused : 1;
564 bool m_seeking : 1; 561 bool m_seeking : 1;
565 562
566 // data has not been loaded since sending a "stalled" event 563 // data has not been loaded since sending a "stalled" event
567 bool m_sentStalledEvent : 1; 564 bool m_sentStalledEvent : 1;
568 565
569 // time has not changed since sending an "ended" event 566 // time has not changed since sending an "ended" event
570 bool m_sentEndEvent : 1; 567 bool m_sentEndEvent : 1;
571 568
572 bool m_pausedInternal : 1; 569 bool m_pausedInternal : 1;
fs 2014/09/22 12:31:05 Nit: Remove the actual flag as well.
573 570
574 bool m_closedCaptionsVisible : 1; 571 bool m_closedCaptionsVisible : 1;
575 572
576 bool m_completelyLoaded : 1; 573 bool m_completelyLoaded : 1;
577 bool m_havePreparedToPlay : 1; 574 bool m_havePreparedToPlay : 1;
578 bool m_delayingLoadForPreloadNone : 1; 575 bool m_delayingLoadForPreloadNone : 1;
579 576
580 bool m_tracksAreReady : 1; 577 bool m_tracksAreReady : 1;
581 bool m_haveVisibleTextTrack : 1; 578 bool m_haveVisibleTextTrack : 1;
582 bool m_processingPreferenceChange : 1; 579 bool m_processingPreferenceChange : 1;
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
636 inline bool isHTMLMediaElement(const HTMLElement& element) 633 inline bool isHTMLMediaElement(const HTMLElement& element)
637 { 634 {
638 return isHTMLAudioElement(element) || isHTMLVideoElement(element); 635 return isHTMLAudioElement(element) || isHTMLVideoElement(element);
639 } 636 }
640 637
641 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLMediaElement); 638 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLMediaElement);
642 639
643 } // namespace blink 640 } // namespace blink
644 641
645 #endif // HTMLMediaElement_h 642 #endif // HTMLMediaElement_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698