Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 594493002: [turbofan] Add operators for float32 support. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add operators for float32 support. This adds Float32Constant, ChangeFloat32ToFloat64 and TruncateFloat64ToFloat32 operators. TEST=compiler-unittests BUG=v8:3589 LOG=n R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24112

Patch Set 1 #

Patch Set 2 : Updates #

Total comments: 4

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -100 lines) Patch
M src/compiler/common-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/common-operator.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/common-operator-unittest.cc View 1 2 2 chunks +19 lines, -0 lines 0 comments Download
M src/compiler/graph-unittest.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/graph-unittest.cc View 1 2 3 chunks +13 lines, -2 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +13 lines, -13 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 2 3 chunks +16 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer-unittest.cc View 1 2 3 chunks +62 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-unittest.cc View 1 chunk +27 lines, -26 lines 0 comments Download
M src/compiler/node-matchers.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +59 lines, -56 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/conversions.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/conversions-inl.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
PTAL
6 years, 3 months ago (2014-09-22 10:49:57 UTC) #2
titzer
lgtm with comments https://codereview.chromium.org/594493002/diff/20001/src/compiler/machine-operator-reducer.cc File src/compiler/machine-operator-reducer.cc (right): https://codereview.chromium.org/594493002/diff/20001/src/compiler/machine-operator-reducer.cc#newcode435 src/compiler/machine-operator-reducer.cc:435: case IrOpcode::kTruncateFloat64ToFloat32: { What about reducing ...
6 years, 3 months ago (2014-09-22 11:24:54 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/594493002/diff/20001/src/compiler/machine-operator-reducer.cc File src/compiler/machine-operator-reducer.cc (right): https://codereview.chromium.org/594493002/diff/20001/src/compiler/machine-operator-reducer.cc#newcode435 src/compiler/machine-operator-reducer.cc:435: case IrOpcode::kTruncateFloat64ToFloat32: { On 2014/09/22 11:24:54, titzer wrote: > ...
6 years, 3 months ago (2014-09-22 11:37:53 UTC) #4
Benedikt Meurer
6 years, 3 months ago (2014-09-22 11:42:30 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 24112 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698