Issue 594403005: Use reset() to delete the contents of a scoped_ptr, not Pass().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 594403005: Use reset() to delete the contents of a scoped_ptr, not Pass(). (Closed)

Created:
6 years, 2 months ago by danakj

Modified:
6 years, 2 months ago

Reviewers:
michaeln, jsbell, cmumford

CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford, jamesr, piman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Use reset() to delete the contents of a scoped_ptr, not Pass(). R=cmumford@chromium.org, jsbell@chromium.org, michaeln@chromium.org BUG=418297 Committed: https://crrev.com/d4c67a01d6f299b180972497d6e943e686b83049 Cr-Commit-Position: refs/heads/master@{#297115}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	content/browser/indexed_db/leveldb/leveldb_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

jsbell

LGTM No idea why it was like that. Hopefully something dumb like the semi-automated WebKit->Chromium ...

6 years, 2 months ago (2014-09-27 19:35:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594403005/1

6 years, 2 months ago (2014-09-27 19:36:38 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as f21cee756e5e54f0723348439cb51d6fe0a1e5db

6 years, 2 months ago (2014-09-27 20:04:11 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-09-27 20:05:04 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d4c67a01d6f299b180972497d6e943e686b83049
Cr-Commit-Position: refs/heads/master@{#297115}