components/gcm_driver/gcm_driver_android.cc - Issue 594383003: [GCM] Passing GCMClient::AccountTokenInfo list to GCMDriver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_driver_android.cc

Issue 594383003: [GCM] Passing GCMClient::AccountTokenInfo list to GCMDriver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@account-mapper

Patch Set: Rebased Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/gcm_driver/gcm_driver.h ('K') | « components/gcm_driver/gcm_driver_android.h ('k') | components/gcm_driver/gcm_driver_desktop.h » ('j') | components/gcm_driver/gcm_driver_desktop.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_driver_android.cc

diff --git a/components/gcm_driver/gcm_driver_android.cc b/components/gcm_driver/gcm_driver_android.cc

index 69da4c5e69dd449d3703b09002cc691afa11e96d..7bbd817e3f6f1298c43f9b77a65202c851a56399 100644

--- a/components/gcm_driver/gcm_driver_android.cc

+++ b/components/gcm_driver/gcm_driver_android.cc

@@ -139,6 +139,10 @@ void GCMDriverAndroid::SetGCMRecording(const GetGCMStatisticsCallback& callback,

NOTIMPLEMENTED();

}

+void FakeGCMDriver::SetAccountTokens(

jianli 2014/09/25 20:26:45 I do not think this will compile.

fgorski 2014/09/26 22:51:42 Done.

+ const std::vector<GCMClient::AccountTokenInfo>& account_tokens) {

jianli 2014/09/25 20:26:45 Please add either "NOTIMPLEMENTED()" or comment "N

fgorski 2014/09/26 22:51:42 Done. And added to the other account handling meth

void GCMDriverAndroid::UpdateAccountMapping(

const AccountMapping& account_mapping) {

}