Change behaviour of the Alt-] and Alt-[ keys so that it cycles through SnapLeft/SnapRight to DockLe…

ash/wm/workspace/workspace_layout_manager.cc

Index: ash/wm/workspace/workspace_layout_manager.cc
diff --git a/ash/wm/workspace/workspace_layout_manager.cc b/ash/wm/workspace/workspace_layout_manager.cc
index 63c4aed0e71112d817c63f2d2bd71d113efe85f6..a6fde9c6d5693b9f96c9378ac6bd07ff5bd24cd3 100644
--- a/ash/wm/workspace/workspace_layout_manager.cc
+++ b/ash/wm/workspace/workspace_layout_manager.cc
@@ -12,6 +12,7 @@
 #include "ash/session/session_state_delegate.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shell.h"
+#include "ash/shell_window_ids.h"
 #include "ash/wm/always_on_top_controller.h"
 #include "ash/wm/window_animations.h"
 #include "ash/wm/window_positioner.h"
@@ -260,6 +261,22 @@ void WorkspaceLayoutManager::OnWindowActivated(aura::Window* gained_active,
 //////////////////////////////////////////////////////////////////////////////
 // WorkspaceLayoutManager, wm::WindowStateObserver implementation:
 
+void WorkspaceLayoutManager::OnPreWindowStateTypeChange(

[varkha, 2014/09/24 03:16:23]

Can this code be placed in some place that is docking-specific or maybe in
window state classes that are more aware? We were trying to limit how much the
rest of the layout managers know about docking. Same goes for panels.

[dtapuska, 2014/09/25 23:27:09]

see comment in panel_layout_manager.cc

+    wm::WindowState* window_state,
+    wm::WindowStateType old_type) {
+  aura::Window* window = window_state->window();
+  if (window_state->IsDocked()) {
+    // Reparent the window into the docked windows container in order to get it
+    // on top of other docked windows.
+    aura::Window* docked_container = Shell::GetContainer(
+        window->GetRootWindow(),
+        kShellWindowId_DockedContainer);
+    wm::ReparentChildWithTransientChildren(window,
+                                           window->parent(),
+                                           docked_container);
+  }
+}
+
 void WorkspaceLayoutManager::OnPostWindowStateTypeChange(
     wm::WindowState* window_state,
     wm::WindowStateType old_type) {