Change behaviour of the Alt-] and Alt-[ keys so that it cycles through SnapLeft/SnapRight to DockLe…

ash/wm/workspace/workspace_layout_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/workspace/workspace_layout_manager.h"
 
 #include <algorithm>
 
 #include "ash/display/display_controller.h"
 #include "ash/root_window_controller.h"
 #include "ash/screen_util.h"
 #include "ash/session/session_state_delegate.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shell.h"
+#include "ash/shell_window_ids.h"
 #include "ash/wm/always_on_top_controller.h"
 #include "ash/wm/window_animations.h"
 #include "ash/wm/window_positioner.h"
 #include "ash/wm/window_properties.h"
 #include "ash/wm/window_state.h"
 #include "ash/wm/window_util.h"
 #include "ash/wm/wm_event.h"
 #include "ash/wm/workspace/workspace_layout_manager_delegate.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/window.h"
@@ skipping 228 matching lines @@
     window_state->Unminimize();
     DCHECK(!window_state->IsMinimized());
   }
   UpdateFullscreenState();
   UpdateShelfVisibility();
 }
 
 //////////////////////////////////////////////////////////////////////////////
 // WorkspaceLayoutManager, wm::WindowStateObserver implementation:
 
+void WorkspaceLayoutManager::OnPreWindowStateTypeChange(

[varkha, 2014/09/24 03:16:23]

Can this code be placed in some place that is docking-specific or maybe in
window state classes that are more aware? We were trying to limit how much the
rest of the layout managers know about docking. Same goes for panels.

[dtapuska, 2014/09/25 23:27:09]

see comment in panel_layout_manager.cc

+    wm::WindowState* window_state,
+    wm::WindowStateType old_type) {
+  aura::Window* window = window_state->window();
+  if (window_state->IsDocked()) {
+    // Reparent the window into the docked windows container in order to get it
+    // on top of other docked windows.
+    aura::Window* docked_container = Shell::GetContainer(
+        window->GetRootWindow(),
+        kShellWindowId_DockedContainer);
+    wm::ReparentChildWithTransientChildren(window,
+                                           window->parent(),
+                                           docked_container);
+  }
+}
+
 void WorkspaceLayoutManager::OnPostWindowStateTypeChange(
     wm::WindowState* window_state,
     wm::WindowStateType old_type) {
 
   // Notify observers that fullscreen state may be changing.
   if (window_state->IsFullscreen() ||
       old_type == wm::WINDOW_STATE_TYPE_FULLSCREEN) {
     UpdateFullscreenState();
   }
 
@@ skipping 49 matching lines @@
   bool is_fullscreen = GetRootWindowController(
       window_->GetRootWindow())->GetWindowForFullscreenMode() != NULL;
   if (is_fullscreen != is_fullscreen_) {
     ash::Shell::GetInstance()->NotifyFullscreenStateChange(
         is_fullscreen, window_->GetRootWindow());
     is_fullscreen_ = is_fullscreen;
   }
 }
 
 }  // namespace ash