Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 594293002: Move painting code from RenderGrid to GridPainter. (Closed)

Created:
6 years, 2 months ago by chrishtr
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, rune+blink, svillar, zoltan1
Project:
blink
Visibility:
Public.

Description

Move painting code from RenderGrid to GridPainter. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182521

Patch Set 1 #

Patch Set 2 : Fix. #

Patch Set 3 : Fix debug build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -86 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + Source/core/paint/GridPainter.h View 1 chunk +11 lines, -11 lines 0 comments Download
A Source/core/paint/GridPainter.cpp View 1 1 chunk +89 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderGrid.h View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 2 chunks +2 lines, -72 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
chrishtr
6 years, 2 months ago (2014-09-23 19:05:33 UTC) #2
leviw_travelin_and_unemployed
http://religion.ua.edu/blog/wp-content/uploads/2014/02/thumbsup.gif lgtm.
6 years, 2 months ago (2014-09-23 19:11:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594293002/40001
6 years, 2 months ago (2014-09-23 21:26:18 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-23 22:47:19 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 182521

Powered by Google App Engine
This is Rietveld 408576698