Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Unified Diff: Source/core/storage/StorageArea.h

Issue 594083002: Make StorageArea cleanly observe its cached frame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make FrameDestructionObserver::observeFrame() protected again Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/LocalFrame.cpp ('k') | Source/core/storage/StorageArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/storage/StorageArea.h
diff --git a/Source/core/storage/StorageArea.h b/Source/core/storage/StorageArea.h
index 38763b8c9ceca814b65d1062347f4fa17cebd070..f446d56b1d2a88678b6b9a718bcbeb63850fe388 100644
--- a/Source/core/storage/StorageArea.h
+++ b/Source/core/storage/StorageArea.h
@@ -26,6 +26,7 @@
#ifndef StorageArea_h
#define StorageArea_h
+#include "core/frame/FrameDestructionObserver.h"
#include "platform/heap/Handle.h"
#include "wtf/OwnPtr.h"
#include "wtf/PassOwnPtr.h"
@@ -47,7 +48,8 @@ enum StorageType {
SessionStorage
};
-class StorageArea FINAL : public NoBaseWillBeGarbageCollectedFinalized<StorageArea> {
+class StorageArea FINAL : public NoBaseWillBeGarbageCollectedFinalized<StorageArea>, public FrameDestructionObserver {
+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(StorageArea);
public:
static PassOwnPtrWillBeRawPtr<StorageArea> create(PassOwnPtr<WebStorageArea>, StorageType);
@@ -80,7 +82,6 @@ private:
OwnPtr<WebStorageArea> m_storageArea;
StorageType m_storageType;
- RawPtrWillBeMember<LocalFrame> m_canAccessStorageCachedFrame;
bool m_canAccessStorageCachedResult;
};
« no previous file with comments | « Source/core/frame/LocalFrame.cpp ('k') | Source/core/storage/StorageArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698