Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: Source/core/storage/StorageArea.h

Issue 594083002: Make StorageArea cleanly observe its cached frame (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make FrameDestructionObserver::observeFrame() protected again Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/LocalFrame.cpp ('k') | Source/core/storage/StorageArea.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All Rights Reserved. 2 * Copyright (C) 2009 Google Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY GOOGLE INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY GOOGLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL GOOGLE INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL GOOGLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef StorageArea_h 26 #ifndef StorageArea_h
27 #define StorageArea_h 27 #define StorageArea_h
28 28
29 #include "core/frame/FrameDestructionObserver.h"
29 #include "platform/heap/Handle.h" 30 #include "platform/heap/Handle.h"
30 #include "wtf/OwnPtr.h" 31 #include "wtf/OwnPtr.h"
31 #include "wtf/PassOwnPtr.h" 32 #include "wtf/PassOwnPtr.h"
32 #include "wtf/text/WTFString.h" 33 #include "wtf/text/WTFString.h"
33 34
34 namespace blink { 35 namespace blink {
35 36
36 class ExceptionState; 37 class ExceptionState;
37 class LocalFrame; 38 class LocalFrame;
38 class KURL; 39 class KURL;
39 class Page; 40 class Page;
40 class SecurityOrigin; 41 class SecurityOrigin;
41 class Storage; 42 class Storage;
42 class WebStorageArea; 43 class WebStorageArea;
43 class WebStorageNamespace; 44 class WebStorageNamespace;
44 45
45 enum StorageType { 46 enum StorageType {
46 LocalStorage, 47 LocalStorage,
47 SessionStorage 48 SessionStorage
48 }; 49 };
49 50
50 class StorageArea FINAL : public NoBaseWillBeGarbageCollectedFinalized<StorageAr ea> { 51 class StorageArea FINAL : public NoBaseWillBeGarbageCollectedFinalized<StorageAr ea>, public FrameDestructionObserver {
52 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(StorageArea);
51 public: 53 public:
52 static PassOwnPtrWillBeRawPtr<StorageArea> create(PassOwnPtr<WebStorageArea> , StorageType); 54 static PassOwnPtrWillBeRawPtr<StorageArea> create(PassOwnPtr<WebStorageArea> , StorageType);
53 55
54 virtual ~StorageArea(); 56 virtual ~StorageArea();
55 57
56 // The HTML5 DOM Storage API 58 // The HTML5 DOM Storage API
57 unsigned length(ExceptionState&, LocalFrame* sourceFrame); 59 unsigned length(ExceptionState&, LocalFrame* sourceFrame);
58 String key(unsigned index, ExceptionState&, LocalFrame* sourceFrame); 60 String key(unsigned index, ExceptionState&, LocalFrame* sourceFrame);
59 String getItem(const String& key, ExceptionState&, LocalFrame* sourceFrame); 61 String getItem(const String& key, ExceptionState&, LocalFrame* sourceFrame);
60 void setItem(const String& key, const String& value, ExceptionState&, LocalF rame* sourceFrame); 62 void setItem(const String& key, const String& value, ExceptionState&, LocalF rame* sourceFrame);
(...skipping 12 matching lines...) Expand all
73 75
74 void trace(Visitor*); 76 void trace(Visitor*);
75 77
76 private: 78 private:
77 StorageArea(PassOwnPtr<WebStorageArea>, StorageType); 79 StorageArea(PassOwnPtr<WebStorageArea>, StorageType);
78 80
79 static bool isEventSource(Storage*, WebStorageArea* sourceAreaInstance); 81 static bool isEventSource(Storage*, WebStorageArea* sourceAreaInstance);
80 82
81 OwnPtr<WebStorageArea> m_storageArea; 83 OwnPtr<WebStorageArea> m_storageArea;
82 StorageType m_storageType; 84 StorageType m_storageType;
83 RawPtrWillBeMember<LocalFrame> m_canAccessStorageCachedFrame;
84 bool m_canAccessStorageCachedResult; 85 bool m_canAccessStorageCachedResult;
85 }; 86 };
86 87
87 } // namespace blink 88 } // namespace blink
88 89
89 #endif // StorageArea_h 90 #endif // StorageArea_h
OLDNEW
« no previous file with comments | « Source/core/frame/LocalFrame.cpp ('k') | Source/core/storage/StorageArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698