Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 594043002: Change ScriptInjection to work with WebLocalFrames. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change ScriptInjection to work with WebLocalFrames. This is to help unblock some of the Blink work to move local frame only APIs off WebFrame. Strictly speaking, all that was required to unblock this bug was to manually coerce the WebFrame to a WebLocalFrame for the call to setIsolatedWorldHumanReadableName. However, it never makes sense to inject script on a remote frame, so I've updated ScriptInjection to just work with local frames where possible. Code that uses ScriptInjection now does the type coercion at the class boundary. As extensions code is gradually updated to understand out-of-process iframes, these manual type coercions should disappear. BUG=416659 Committed: https://crrev.com/2e44917894a92a0d6fb0e56e3220811f811d1c8e Cr-Commit-Position: refs/heads/master@{#296345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
M extensions/renderer/script_injection.h View 5 chunks +6 lines, -6 lines 0 comments Download
M extensions/renderer/script_injection.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M extensions/renderer/script_injection_manager.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M extensions/renderer/user_script_set.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
dcheng
If anyone on the extensions team would like to sit down some time and figure ...
6 years, 3 months ago (2014-09-23 17:14:58 UTC) #2
dcheng
(Also, this is blocking https://codereview.chromium.org/595713002 from landing.)
6 years, 3 months ago (2014-09-23 17:25:33 UTC) #3
Yoyo Zhou
LGTM, seems reasonable, but I'm not really familiar with this side of things.
6 years, 3 months ago (2014-09-23 23:20:25 UTC) #4
dcheng
Do you have any recommendations for who to talk to about these sort of issues ...
6 years, 3 months ago (2014-09-24 03:46:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594043002/1
6 years, 3 months ago (2014-09-24 03:47:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 57de315ec54e7bb8ca7f76bb1313880b61e99e02
6 years, 3 months ago (2014-09-24 04:31:06 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 04:31:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e44917894a92a0d6fb0e56e3220811f811d1c8e
Cr-Commit-Position: refs/heads/master@{#296345}

Powered by Google App Engine
This is Rietveld 408576698