Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 594033002: Remove PagePopup runtime flag (status=stable) for blink (Closed)

Created:
6 years, 3 months ago by heeyoun.lee
Modified:
6 years, 2 months ago
Reviewers:
eseidel
CC:
blink-reviews, kangil_, pdr., tfarina
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove PagePopup runtime flag (status=stable) for blink BUG=402536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183390

Patch Set 1 #

Patch Set 2 : Fix for commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M Source/core/page/PagePopupController.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/WindowPagePopup.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 2 chunks +2 lines, -5 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
heeyoun.lee
This is for blink. PTAL chromium : https://codereview.chromium.org/586053003/
6 years, 3 months ago (2014-09-23 07:22:01 UTC) #2
eseidel
lgtm
6 years, 2 months ago (2014-10-07 16:09:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594033002/1
6 years, 2 months ago (2014-10-08 02:01:57 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/platform/RuntimeEnabledFeatures.in: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-08 02:02:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594033002/20001
6 years, 2 months ago (2014-10-08 05:28:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/12990)
6 years, 2 months ago (2014-10-08 05:41:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594033002/20001
6 years, 2 months ago (2014-10-08 06:50:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 183390
6 years, 2 months ago (2014-10-08 07:03:33 UTC) #14
tkent
6 years, 2 months ago (2014-10-08 07:41:15 UTC) #15
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/641553002/ by tkent@chromium.org.

The reason for reverting is: The PagePopup flag is not removable..

Powered by Google App Engine
This is Rietveld 408576698