Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 593883002: [exp] Browser-side fling.

Created:
6 years, 3 months ago by sadrul
Modified:
6 years, 2 months ago
Reviewers:
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jdduke+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@fling-curve-config-remove
Project:
chromium
Visibility:
Public.

Description

[exp] Browser-side fling. When a FlingStart event comes in, start generating a sequence of ScrollUpdate events, and send those to the renderer instead of the FlingStart event. This moves the control of the fling scroll entirely in the browser process. Details: . The FlingStart event reaches InputRouterImpl. Instead of forwarding this event to the renderer, the input router replaces it with a sequence of ScrollUpdate[WithoutPropagation] events. The first ScrollUpdate event is generated and dispatched immediately. . The subsequent ScrollUpdate events are generated hen the ACK for a previous ScrollUpdate[WithoutPropagation] event is received. . The location of all the ScrollUpdate[WithoutPropagation] events are the same as the location of the FlingStart event. . The fling is cancelled when a FlingCancel is dispatched, or when the fling velocity slows down to zero. . The fling is cancelled when an overscroll notification comes in from the renderer. . The fling is cancelled when a ScrollUpdate[WithoutPropagation] comes in as un-consumed (and the scroll-update was sufficiently large, since towards the end of the fling, individual scroll-updates can be too small to cause any scrolls, and can thus be erroneously acked as un-consumed). TODO: . Make sure the fling is stopped at the right times: - when sending a key event, . Flywheel . Aura overscroll . WebView sync BUG=TBD

Patch Set 1 #

Patch Set 2 : tot-merge #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -3 lines) Patch
M content/browser/renderer_host/input/input_router_impl.h View 1 2 2 chunks +27 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 1 2 3 4 5 6 6 chunks +132 lines, -1 line 0 comments Download
M content/common/input/web_input_event_traits.cc View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 1 4 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
sadrul
6 years, 2 months ago (2014-09-26 19:07:03 UTC) #1
Patchset #8 (id:140001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698