Different fonts selected for width calculation and actual painting

In some cases different fonts are selected to get width of string and
to draw text.
In Font.cpp calls, font get changed due to fallback font architecture.
When making calls we need to check if Unicode is present in primary font or not.
 In case of Ellipsis, we need to check if Ellipsis Unicode is present in primary font or not,
if not then use "Dot" Unicode, this is also suggested in CSS3 (http://www.w3.org/TR/2003/CR-css3-text-20030514/)

BUG=416425
TEST=fast/text/ellipsis-platform-font-change.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183597

[h.joshi, 2014-09-24 11:21:07]

h.joshi@samsung.com changed reviewers:
+ behdad@chromium.org, eae@chromium.org

[h.joshi, 2014-09-24 11:21:33]

@Emil/Behdad: Pls review

[eae, 2014-09-24 11:35:39]

https://codereview.chromium.org/593673003/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderText.cpp (right):

https://codereview.chromium.org/593673003/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderText.cpp:757: if (i == start + len)
Instead of reusing i like this why not add a new bool instead?
I.e. keep the index variable local to the loop and change it to do something
like

bool missingGlyph = false;
for (...)
...
  if (!f.primaryFontHasGlyphForCharacter(text[i]) {
    missingGlyph = true;
    break;
  }

Then here replace the "if (i == start + len)" statement with:
if (!missingGlyph)
  return w;

[h.joshi, 2014-09-24 20:25:58]

Made suggested changes, pls review.

https://codereview.chromium.org/593673003/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderText.cpp (right):

https://codereview.chromium.org/593673003/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderText.cpp:757: if (i == start + len)
Okey, done.

[eae, 2014-09-26 13:37:09]

LGTM

[h.joshi, 2014-09-26 17:51:50]

Thank you Emil.

[h.joshi, 2014-09-26 17:51:56]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-09-26 17:52:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/593673003/20001

[commit-bot: I haz the power, 2014-09-26 18:00:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-26 18:00:53]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[h.joshi, 2014-09-26 18:25:41]

h.joshi@samsung.com changed reviewers:
+ tkent@chromium.org

[h.joshi, 2014-09-26 18:26:31]

@tkent: Pls review "Source/wtf/unicode/CharacterNames.h" changes.
Getting "** Presubmit ERRORS **, Missing LGTM from an OWNER " for
CharacterNames.h file.

[tkent, 2014-09-29 00:08:35]

The WTF change looks ok.  However layout test try bots are failing.

[h.joshi, 2014-09-29 19:19:16]

@tkent: Need to update TestExpectation file, as due to
changes in Ellipsis code, related test case reference files
needs to be updated.
 Facing following error when trying to update TestExpectation file for
test cases for which reference rendering needs be to updated.
"A reftest cannot be marked as NeedsRebaseline/NeedsManualRebaseline"

 Not sure about above error, as for previous patches used to specify
"NeedsRebaseline" only, searching for the above error.

[tkent, 2014-09-30 01:35:05]

On 2014/09/29 19:19:16, h.joshi wrote:
> @tkent: Need to update TestExpectation file, as due to
> changes in Ellipsis code, related test case reference files
> needs to be updated.
>  Facing following error when trying to update TestExpectation file for
> test cases for which reference rendering needs be to updated.
> "A reftest cannot be marked as NeedsRebaseline/NeedsManualRebaseline"
> 
>  Not sure about above error, as for previous patches used to specify
> "NeedsRebaseline" only, searching for the above error.

I see.  So, you need to update *-expected.html for this error, instead of adding
NeedsRebaseline.

[h.joshi, 2014-10-06 14:26:46]

@tkent: Updated Test expectation file, now Windows, Mac and Linux
bots are green which were failing previously.
Issue which was initially reported for which "-expected.html" needs change
is not observed now, seems to be some flaky or bot issue. That particular
test is not added to Test Expectation file.

Pls review changes related to WTF.

[tkent, 2014-10-07 01:42:28]

ok, rs lgtm

[tkent, 2014-10-07 01:42:32]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-10-07 01:44:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/593673003/80001

[commit-bot: I haz the power, 2014-10-07 01:44:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-07 01:44:51]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 succeeded at 1370 (offset -3 lines).
  Hunk #2 FAILED at 1462.
  1 out of 2 hunks FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
badcb025a4bf516a74567906fffcfd08ec29f60a..9f1c2b2d6512a443515389e302f4991003d0c0c1
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1373,10 +1373,6 @@ crbug.com/417181
http/tests/xmlhttprequest/abort-on-changestate-headers-received
 
 crbug.com/417229 fast/events/touch/gesture/gesture-tap-result.html [ Pass
Failure ]
 
-crbug.com/418021 inspector/profiler/heap-snapshot-inspect-dom-wrapper.html [
Pass Crash Timeout ]
-
-crbug.com/418324 http/tests/media/media-source/mediasource-redundant-seek.html
[ Pass Failure ]
-
 crbug.com/340522 [ Mac ]
fast/forms/calendar-picker/calendar-picker-appearance.html [ Pass
ImageOnlyFailure ]
 
 crbug.com/418091 [ Mac ] editing/pasteboard/copy-crash.html [ Pass Timeout ]
@@ -1466,3 +1462,16 @@ crbug.com/420008 [ Win ]
virtual/implsidepainting/inspector/tracing/timeline-rec
 crbug.com/420008 [ Win ]
virtual/implsidepainting/inspector/tracing/timeline-script-tag-1.html [ Pass
Failure Timeout ]
 
 crbug.com/420307 [ Win ] http/tests/serviceworker/fetch-frame-resource.html [
Pass Timeout ]
+
+# Test case needs to be updated after
https://codereview.chromium.org/593673003/
+crbug.com/416425 fast/text/ellipsis-platform-font-change.html [ NeedsRebaseline
]
+crbug.com/416425 [ Mac Win ]
virtual/antialiasedtext/fast/text/ellipsis-platform-font-change.html [
NeedsRebaseline ]
+crbug.com/416425 svg/text/text-overflow-ellipsis-svgfont.html [ NeedsRebaseline
]
+crbug.com/416425 [ Mac ] fast/text/line-break-after-question-mark.html [
NeedsRebaseline ]
+
+# Failure on Linux Leak bot
+crbug.com/417752 [ Linux ] storage/websql/sql-error-codes.html [ Pass Failure ]
+
+crbug.com/418021 inspector/profiler/heap-snapshot-inspect-dom-wrapper.html [
Pass Crash Timeout ]
+
+crbug.com/418324 http/tests/media/media-source/mediasource-redundant-seek.html
[ Pass Failure ]

[tkent, 2014-10-07 01:48:47]

https://codereview.chromium.org/593673003/diff/80001/LayoutTests/TestExpectat...
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/593673003/diff/80001/LayoutTests/TestExpectat...
LayoutTests/TestExpectations:1472: # Failure on Linux Leak bot
Please do not add unrelated tests.
This CL is not responsible to add existing failures.

[h.joshi, 2014-10-13 08:49:51]

https://codereview.chromium.org/593673003/diff/80001/LayoutTests/TestExpectat...
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/593673003/diff/80001/LayoutTests/TestExpectat...
LayoutTests/TestExpectations:1472: # Failure on Linux Leak bot
Done, these cases got added due to mistake in rebasing patch.

[h.joshi, 2014-10-13 08:50:02]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-10-13 08:50:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/593673003/180001

[commit-bot: I haz the power, 2014-10-13 11:01:15]

Committed patchset #6 (id:180001) as 183597

[cbiesinger, 2014-10-13 15:16:39]

A revert of this CL (patchset #6 id:180001) has been created in
https://codereview.chromium.org/648233002/ by cbiesinger@chromium.org.

The reason for reverting is: This broke fast/css/font-face-opentype.html and
fast/text/line-break-after-question-mark.html on WinXP

https://sheriff-o-matic.appspot.com/blink/failure/webkit_tests%3A%3Afast%2Fcs....