Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 593653003: Refactoring AudioParameters |operator==| to |Equals()| method (Closed)

Created:
6 years, 3 months ago by burnik
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactoring AudioParameters |operator==| to |Equals()| method The == operator is re-factored to: bool Equals(const AudioParameters& other) const; This will also help avoid expressions like !(a == b), transforming them to !a.Equals(b) instead. BUG=416506 Committed: https://crrev.com/015d99082c40d3ee2a29a51114a15ddb8d9a3f54 Cr-Commit-Position: refs/heads/master@{#296230}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Moved implementation to .cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M content/renderer/media/webrtc_local_audio_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_manager_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/audio_parameters.h View 1 2 chunks +3 lines, -11 lines 0 comments Download
M media/audio/audio_parameters.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
DaleCurtis
https://codereview.chromium.org/593653003/diff/1/media/audio/audio_parameters.h File media/audio/audio_parameters.h (right): https://codereview.chromium.org/593653003/diff/1/media/audio/audio_parameters.h#newcode97 media/audio/audio_parameters.h:97: bool Equals(const AudioParameters& other) const { Move into class ...
6 years, 3 months ago (2014-09-22 21:30:24 UTC) #3
henrika (OOO until Aug 14)
LGTM assuming that you move as Dale suggests
6 years, 3 months ago (2014-09-23 07:22:33 UTC) #4
burnik
Moved implementation to .cc
6 years, 3 months ago (2014-09-23 08:22:45 UTC) #5
no longer working on chromium
On 2014/09/23 08:22:45, burnik wrote: > Moved implementation to .cc lgtm
6 years, 3 months ago (2014-09-23 11:47:14 UTC) #6
tommi (sloooow) - chröme
lgtm
6 years, 3 months ago (2014-09-23 12:21:56 UTC) #7
DaleCurtis
lgtm
6 years, 3 months ago (2014-09-23 17:25:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593653003/20001
6 years, 3 months ago (2014-09-23 17:59:06 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4f9c16db717de1f134ef1a3949f8dc643bc09c67
6 years, 3 months ago (2014-09-23 20:53:44 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 20:54:43 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/015d99082c40d3ee2a29a51114a15ddb8d9a3f54
Cr-Commit-Position: refs/heads/master@{#296230}

Powered by Google App Engine
This is Rietveld 408576698