Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: media/audio/audio_parameters.h

Issue 593653003: Refactoring AudioParameters |operator==| to |Equals()| method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved implementation to .cc Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_manager_base.cc ('k') | media/audio/audio_parameters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_parameters.h
diff --git a/media/audio/audio_parameters.h b/media/audio/audio_parameters.h
index 03fe043dfadd53e4ae4bf75edc1e9ce5eeadcacf..222132ef99b7a97947f9da11c7e37b0f09f924af 100644
--- a/media/audio/audio_parameters.h
+++ b/media/audio/audio_parameters.h
@@ -85,6 +85,9 @@ class MEDIA_EXPORT AudioParameters {
// and sample_rate().
base::TimeDelta GetBufferDuration() const;
+ // Comparison with other AudioParams.
+ bool Equals(const AudioParameters& other) const;
+
Format format() const { return format_; }
ChannelLayout channel_layout() const { return channel_layout_; }
int sample_rate() const { return sample_rate_; }
@@ -93,17 +96,6 @@ class MEDIA_EXPORT AudioParameters {
int channels() const { return channels_; }
int effects() const { return effects_; }
- // Comparison with other AudioParams.
- bool operator==(const AudioParameters& other) const {
- return format_ == other.format() &&
- sample_rate_ == other.sample_rate() &&
- channel_layout_ == other.channel_layout() &&
- channels_ == other.channels() &&
- bits_per_sample_ == other.bits_per_sample() &&
- frames_per_buffer_ == other.frames_per_buffer() &&
- effects_ == other.effects();
- }
-
private:
// These members are mutable to support entire struct assignment. They should
// not be mutated individually.
« no previous file with comments | « media/audio/audio_manager_base.cc ('k') | media/audio/audio_parameters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698