content/browser/frame_host/navigation_controller_impl_unittest.cc - Issue 593503003: Support error handling for Surface readbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted code and fixed build issue in test. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc

index ae7ad90f1e4d51f7decb546297d3535b0a0b6c05..6faf9e76470375e8ced83886800f03f2fcd7b40f 100644

--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc

@@ -81,7 +81,7 @@ class MockScreenshotManager : public content::NavigationEntryScreenshotManager {

1, 1, kAlpha_8_SkColorType, kPremul_SkAlphaType));

bitmap.eraseARGB(0, 0, 0, 0);

encoding_screenshot_in_progress_ = true;

- OnScreenshotTaken(entry->GetUniqueID(), true, bitmap);

+ OnScreenshotTaken(entry->GetUniqueID(), bitmap, content::READBACK_SUCCESS);

WaitUntilScreenshotIsReady();

}