content/browser/devtools/protocol/page_handler.cc - Issue 593503003: Support error handling for Surface readbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/page_handler.cc

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted code and fixed build issue in test. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/page_handler.cc

diff --git a/content/browser/devtools/protocol/page_handler.cc b/content/browser/devtools/protocol/page_handler.cc

index d0e8496562e1cca914147626f48a9324b70f73ec..d1d8da6b1cd4e3ae47b0d84e861860793d4e8418 100644

--- a/content/browser/devtools/protocol/page_handler.cc

+++ b/content/browser/devtools/protocol/page_handler.cc

@@ -483,9 +483,9 @@ void PageHandler::ScreencastFrameCaptured(

const std::string& format,

int quality,

const cc::CompositorFrameMetadata& metadata,

- bool success,

- const SkBitmap& bitmap) {

- if (!success) {

+ const SkBitmap& bitmap,

+ ReadbackResponse response) {

+ if (response != READBACK_SUCCESS) {

if (capture_retry_count_) {

--capture_retry_count_;

base::MessageLoop::current()->PostDelayedTask(