chrome/browser/ui/fullscreen/flash_fullscreen_interactive_browsertest.cc - Issue 593503003: Support error handling for Surface readbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/fullscreen/flash_fullscreen_interactive_browsertest.cc

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted code and fixed build issue in test. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/thumbnails/thumbnail_tab_helper.cc ('k') | chrome/browser/ui/pdf/pdf_browsertest_base.h » ('j') | content/browser/compositor/delegated_frame_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/fullscreen/flash_fullscreen_interactive_browsertest.cc

diff --git a/chrome/browser/ui/fullscreen/flash_fullscreen_interactive_browsertest.cc b/chrome/browser/ui/fullscreen/flash_fullscreen_interactive_browsertest.cc

index 4d4f96e371454882afb764195ba3aab1445cbbb8..030456b6fa07bb378fd21b548e8f76963f7573c4 100644

--- a/chrome/browser/ui/fullscreen/flash_fullscreen_interactive_browsertest.cc

+++ b/chrome/browser/ui/fullscreen/flash_fullscreen_interactive_browsertest.cc

@@ -240,9 +240,9 @@ class FlashFullscreenInteractiveBrowserTest : public OutOfProcessPPAPITest {

static void CheckBitmapForFillColor(SkColor expected_color,

bool* is_expected_color,

const base::Closure& done_cb,

- bool success,

- const SkBitmap& bitmap) {

- if (success) {

+ const SkBitmap& bitmap,

+ content::ReadbackResponse response) {

+ if (response == content::READBACK_SUCCESS) {

SkAutoLockPixels lock_pixels(bitmap);

if (bitmap.width() > 0 && bitmap.height() > 0)

*is_expected_color = (bitmap.getColor(0, 0) == expected_color);