Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: chrome/browser/thumbnails/thumbnail_tab_helper.cc

Issue 593503003: Support error handling for Surface readbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted code and fixed build issue in test. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/thumbnails/thumbnail_tab_helper.cc
diff --git a/chrome/browser/thumbnails/thumbnail_tab_helper.cc b/chrome/browser/thumbnails/thumbnail_tab_helper.cc
index d6c423ca93bf9caa88011070a1eb33a2574d9d20..e28c9dc6494f71ba1766d9a3d331a9903ec950e5 100644
--- a/chrome/browser/thumbnails/thumbnail_tab_helper.cc
+++ b/chrome/browser/thumbnails/thumbnail_tab_helper.cc
@@ -64,9 +64,9 @@ void UpdateThumbnail(const ThumbnailingContext& context,
void ProcessCapturedBitmap(scoped_refptr<ThumbnailingContext> context,
scoped_refptr<ThumbnailingAlgorithm> algorithm,
- bool succeeded,
- const SkBitmap& bitmap) {
- if (!succeeded)
+ const SkBitmap& bitmap,
+ content::ReadbackResponse response) {
+ if (response != content::READBACK_SUCCESS)
return;
// On success, we must be on the UI thread (on failure because of shutdown we

Powered by Google App Engine
This is Rietveld 408576698