Support error handling for Surface readbacks

chrome/browser/thumbnails/thumbnail_tab_helper.cc

Index: chrome/browser/thumbnails/thumbnail_tab_helper.cc
diff --git a/chrome/browser/thumbnails/thumbnail_tab_helper.cc b/chrome/browser/thumbnails/thumbnail_tab_helper.cc
index d6c423ca93bf9caa88011070a1eb33a2574d9d20..b949cc6dab51bb4cd0826e1f1ebc7d2e5017be69 100644
--- a/chrome/browser/thumbnails/thumbnail_tab_helper.cc
+++ b/chrome/browser/thumbnails/thumbnail_tab_helper.cc
@@ -64,9 +64,9 @@ void UpdateThumbnail(const ThumbnailingContext& context,
 
 void ProcessCapturedBitmap(scoped_refptr<ThumbnailingContext> context,
                            scoped_refptr<ThumbnailingAlgorithm> algorithm,
-                           bool succeeded,
-                           const SkBitmap& bitmap) {
-  if (!succeeded)
+                           const SkBitmap& bitmap,
+                           const content::ReadbackResponse& response) {

[sky, 2014/11/11 16:43:18]

We generally don't POD types as const&. For example, see the succeeded you're
replacing.

[sivag, 2014/11/12 18:53:49]

Done.

+  if (response != content::READBACK_SUCCESS)
     return;
 
   // On success, we must be on the UI thread (on failure because of shutdown we