Support error handling for Surface readbacks

chrome/browser/thumbnails/thumbnail_tab_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/thumbnails/thumbnail_tab_helper.h"
 
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/thumbnails/thumbnail_service.h"
 #include "chrome/browser/thumbnails/thumbnail_service_factory.h"
@@ skipping 46 matching lines @@
 void UpdateThumbnail(const ThumbnailingContext& context,
                      const SkBitmap& thumbnail) {
   gfx::Image image = gfx::Image::CreateFrom1xBitmap(thumbnail);
   context.service->SetPageThumbnail(context, image);
   DVLOG(1) << "Thumbnail taken for " << context.url << ": "
            << context.score.ToString();
 }
 
 void ProcessCapturedBitmap(scoped_refptr<ThumbnailingContext> context,
                            scoped_refptr<ThumbnailingAlgorithm> algorithm,
-                           bool succeeded,
-                           const SkBitmap& bitmap) {
-  if (!succeeded)
+                           const SkBitmap& bitmap,
+                           const content::ReadbackResponse& response) {

[sky, 2014/11/11 16:43:18]

We generally don't POD types as const&. For example, see the succeeded you're
replacing.

[sivag, 2014/11/12 18:53:49]

Done.

+  if (response != content::READBACK_SUCCESS)
     return;
 
   // On success, we must be on the UI thread (on failure because of shutdown we
   // are not on the UI thread).
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 
   algorithm->ProcessBitmap(context, base::Bind(&UpdateThumbnail), bitmap);
 }
 
 void AsyncProcessThumbnail(content::WebContents* web_contents,
@@ skipping 140 matching lines @@
         content::NOTIFICATION_RENDER_WIDGET_VISIBILITY_CHANGED,
         content::Source<RenderWidgetHost>(renderer));
   }
 }
 
 void ThumbnailTabHelper::WidgetHidden(RenderWidgetHost* widget) {
   if (!enabled_)
     return;
   UpdateThumbnailIfNecessary(web_contents());
 }