Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Issue 593223003: Fix default value of ExtensionManagement::IndividualSettings (Closed)

Created:
6 years, 2 months ago by binjin
Modified:
6 years, 2 months ago
Reviewers:
scheib, Joao da Silva
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix default value of ExtensionManagement::IndividualSettings This CL fixes a bug in commit b2454381 "Add new ExtensionManagement preference". The default value of IndividualSettings are supposed to be |default_settings_| instead of fallback value for each settings. This bug was not exposed in unit tests since IndividualSettings contains only installation mode settings now. BUG=177351 Committed: https://crrev.com/6a6eb15910c41895e5ebd2eb5fcd785ddc3c277f Cr-Commit-Position: refs/heads/master@{#296475}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes addressing #3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -9 lines) Patch
M chrome/browser/extensions/extension_management.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_management.cc View 1 3 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_management_test_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_management_test_util.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_management_unittest.cc View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
binjin
Please take a look at this fix to a bug in https://codereview.chromium.org/559603002/ (landed as http://crrev.com/b245438121f8dba852268c0bed0359c6f31c50c6 ...
6 years, 2 months ago (2014-09-23 19:32:11 UTC) #2
Joao da Silva
lgtm https://codereview.chromium.org/593223003/diff/1/chrome/browser/extensions/extension_management.cc File chrome/browser/extensions/extension_management.cc (right): https://codereview.chromium.org/593223003/diff/1/chrome/browser/extensions/extension_management.cc#newcode349 chrome/browser/extensions/extension_management.cc:349: IndividualSettings *by_id = AccessById(extension_id); * next to type: ...
6 years, 2 months ago (2014-09-24 11:22:51 UTC) #3
scheib
lgtm
6 years, 2 months ago (2014-09-24 17:13:37 UTC) #4
binjin
https://codereview.chromium.org/593223003/diff/1/chrome/browser/extensions/extension_management.cc File chrome/browser/extensions/extension_management.cc (right): https://codereview.chromium.org/593223003/diff/1/chrome/browser/extensions/extension_management.cc#newcode349 chrome/browser/extensions/extension_management.cc:349: IndividualSettings *by_id = AccessById(extension_id); On 2014/09/24 11:22:51, Joao da ...
6 years, 2 months ago (2014-09-24 17:47:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593223003/20001
6 years, 2 months ago (2014-09-24 17:48:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b588849a4aa2ca696935b128e464fba982722771
6 years, 2 months ago (2014-09-24 18:36:48 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 18:37:33 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a6eb15910c41895e5ebd2eb5fcd785ddc3c277f
Cr-Commit-Position: refs/heads/master@{#296475}

Powered by Google App Engine
This is Rietveld 408576698