Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: chrome/browser/extensions/extension_management_unittest.cc

Issue 593223003: Fix default value of ExtensionManagement::IndividualSettings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes addressing #3 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_management_test_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_management_unittest.cc
diff --git a/chrome/browser/extensions/extension_management_unittest.cc b/chrome/browser/extensions/extension_management_unittest.cc
index e040d5377d1abafde0c6ed6a911a24f45accbd68..9d9189573dfc9cdb15246a175ca75a81b7ba0e16 100644
--- a/chrome/browser/extensions/extension_management_unittest.cc
+++ b/chrome/browser/extensions/extension_management_unittest.cc
@@ -423,6 +423,8 @@ TEST_F(ExtensionManagementServiceTest, NewInstallBlacklist) {
PrefUpdater updater(pref_service_.get());
updater.SetBlacklistedByDefault(false); // Allowed by default.
updater.SetIndividualExtensionInstallationAllowed(kTargetExtension, false);
+ updater.ClearPerExtensionSettings(kTargetExtension2);
+ updater.ClearPerExtensionSettings(kOtherExtension);
}
EXPECT_FALSE(extension_management_->BlacklistedByDefault());
EXPECT_EQ(extension_management_->ReadById(kTargetExtension).installation_mode,
@@ -459,6 +461,8 @@ TEST_F(ExtensionManagementServiceTest, NewInstallWhitelist) {
PrefUpdater updater(pref_service_.get());
updater.SetBlacklistedByDefault(true); // Disallowed by default.
updater.SetIndividualExtensionInstallationAllowed(kTargetExtension, true);
+ updater.ClearPerExtensionSettings(kTargetExtension2);
+ updater.ClearPerExtensionSettings(kOtherExtension);
}
EXPECT_TRUE(extension_management_->BlacklistedByDefault());
EXPECT_EQ(extension_management_->ReadById(kTargetExtension).installation_mode,
@@ -500,6 +504,7 @@ TEST_F(ExtensionManagementServiceTest, NewInstallForcelist) {
PrefUpdater updater(pref_service_.get());
updater.SetIndividualExtensionAutoInstalled(
kTargetExtension, kExampleUpdateUrl, true);
+ updater.ClearPerExtensionSettings(kOtherExtension);
}
EXPECT_EQ(extension_management_->ReadById(kTargetExtension).installation_mode,
ExtensionManagement::INSTALLATION_FORCED);
« no previous file with comments | « chrome/browser/extensions/extension_management_test_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698