Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 593183004: Remove WillRunPageRepeat and DidRunPageRpeat hooks since they are not used. (Closed)

Created:
6 years, 3 months ago by nednguyen
Modified:
6 years, 3 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org, slamm
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove WillRunPageRepeat and DidRunPageRpeat hooks since they are not used. BUG= Committed: https://crrev.com/9677b77e062a7755f626bfb8d7f98785501f6b4a Cr-Commit-Position: refs/heads/master@{#296402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M tools/telemetry/telemetry/page/page_runner.py View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
nednguyen
6 years, 3 months ago (2014-09-23 22:44:55 UTC) #2
nednguyen
6 years, 3 months ago (2014-09-23 22:45:02 UTC) #3
chrishenry
lgtm cc'ing slamm, who's deleting this in his patch too.
6 years, 3 months ago (2014-09-23 22:47:30 UTC) #4
tonyg
lgtm
6 years, 3 months ago (2014-09-23 22:47:52 UTC) #5
nednguyen
6 years, 3 months ago (2014-09-23 22:48:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593183004/1
6 years, 3 months ago (2014-09-23 22:51:05 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-24 04:52:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593183004/1
6 years, 3 months ago (2014-09-24 13:02:55 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 27ea934b73c1c63e5eadfead0d5064dc919ad8df
6 years, 3 months ago (2014-09-24 13:03:23 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 13:03:54 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9677b77e062a7755f626bfb8d7f98785501f6b4a
Cr-Commit-Position: refs/heads/master@{#296402}

Powered by Google App Engine
This is Rietveld 408576698