tools/telemetry/telemetry/page/page_runner.py - Issue 593183004: Remove WillRunPageRepeat and DidRunPageRpeat hooks since they are not used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 593183004: Remove WillRunPageRepeat and DidRunPageRpeat hooks since they are not used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index 6b112e83979e30f37537ec003e67e1fc0d9ed158..d70d3e73052a8afe2b6b89cbaf8c90c52cc955bd 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -423,7 +423,6 @@ def Run(test, page_set, expectations, finder_options, results):

if test.IsExiting():

break

- test.WillRunPageRepeats(page)

for _ in xrange(0, finder_options.page_repeat):

results.WillRunPage(page)

try:

@@ -437,7 +436,6 @@ def Run(test, page_set, expectations, finder_options, results):

if test.discard_first_result:

discard_run = True

results.DidRunPage(page, discard_run=discard_run)

- test.DidRunPageRepeats(page)

if (not max_failures is None and

len(results.failures) > max_failures):

logging.error('Too many failures. Aborting.')

« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »